Skip to content

Tests for adding P2P send and recv nodes - #21

Open
AndyUB wants to merge 1 commit into
dengwxn:unified-op-prfrom
AndyUB:unified-op-pr-test
Open

Tests for adding P2P send and recv nodes#21
AndyUB wants to merge 1 commit into
dengwxn:unified-op-prfrom
AndyUB:unified-op-pr-test

Conversation

@AndyUB

@AndyUB AndyUB commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What is done?

Added tests for _add_p2p_send_node and _add_p2p_recv_node.

What is experimental?

The tests sometimes produce warnings. I don't know how to get rid of the warnings.

core_worker.cc:2728: Failed to register actor. Error message: SchedulingCancelled: Actor creation cancelled. actor_id=68a87fef2fd1d116f38f9f3701000000

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@AndyUB
test: add p2p send/recv nodes
d7913bc 
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
@github-actions

github-actions Bot commented Jul 5, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

2 similar comments
@github-actions

github-actions Bot commented Jul 19, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions

github-actions Bot commented Aug 2, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyUB